Ensure rpmbuild's cleanup doesn't fail due to permissions #3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmatilai
added
bug
handsfree
|
If this breaks something, we're not going to find it by studying this on a petri-dish. |
In rpm < 4.8, %clean was needed to clean up the build root for packages that used one (it was optional before 4.6). Since the introduction of the new %builddir in 9d35c8d, everything the package produces is collected in that one directory that we can and do centrally clean up, making the separate %clean section even more useless. Document %clean as obsolete and drop all the now unnecessary default %clean sections we've been adding for the packages.
Packages may contain files without write permissions, read-only sources and whatnot. Run %_fixperms on the whole builddir before trying to remove it to ensure we don't fail doing our household duties, both on post-cleanup but also before trying to remove an old run, as eg 'rpmbuild -bi' will not run cleanup. It's worth noting that prior to b5f6c64 the build could similarly fail while running it's default %clean. If we hadn't removeed the default %clean, we'd have to do this permission fixup first redundantly for the build root and then for the rest of the %builddir. Also worth noting is that the added test doesn't actually reproduce the issue in the test-suite because it runs as root and root is not bothered by such petty issues as missing read/write permissions to remove. But at least we have a reproducer for the case once rpm-software-management#3005 is done. Fixes: rpm-software-management#2519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in the commit messages, but in short: packages can leave unremovable files in their build directory, run %_fixperms before and after to ensure sufficient permissions to remove %builddir.
%clean is redundant since 9d35c8d, drop default %clean sections and document as obsolete. We still honor a %clean in spec though.
Fixes: #2519