Get rid of pgpGrab() #3013
Merged
Get rid of pgpGrab() #3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpmvs.c is the only one using it in the rpm source and it can be trivially rewritten.
|
Note that pgpGrab() is in the public API. I could not find any usage outside of rpm, though. |
|
Right, I remember coming across this and thinking about removing and then postponing for whatever reason, and here we are. The positive thing is that while it's in the API, it's not in the ABI, so we can remove without soname bumps. Indeed nobody should be using it, and by the looks of things people seem to agree 😆 Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpmvs.c is the only one using it in the rpm source and it can be trivially rewritten.