Allow signing with ECDSA keys #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key import and verification already works, it's just that rpm does not know where to put the signature.
|
See also 23770e1 |
|
Maybe we should put all unknown algorithms into the DSA slots. I think the distinction was just done so that very old rpm versions didn't trip when they saw a non-rsa signature. Another reason could have been to allow both signing with the old RSA/MD5 (for compat reasons) and the new DSA/SHA1 combos. |
|
Clearly it's Monday - took me a few moments to see the difference to 23770e1 😅 I'd be wary of adding any default rule there but clearly ECDSA belongs to DSA as much as EDDSA does, no objection on that. These things should have tests, really. Care to add some, or should I just add a ticket to remind us to add one of these days? |
|
I can add both an ed25519 and an nist p-256 key test. |
|
Ok, done. |
|
Excellent, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key import and verification already works, it's just that rpm does not know where to put the signature.