check that libcrypto supports MD2 #453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not opposed to removing it completely, or hiding it behind ifdef guards, but as long as RPM requires it unconditionally, it should be handled in |
|
Ehm... where does rpm require MD2? It's never been used for anything at all in rpm AFAIK. |
|
Line 179 in 0ac96d5 |
|
The beecrypt glue code in rpm doesn't even support MD2 as digest, so yes, just remove it in digest_openssl.c... |
pmatilai
added a commit
that referenced
this pull request
Jun 26, 2018
Inspired by #453, adding configure-checks for unused digests algorithms seems nonsensical, at no point in rpm history have these algorithms been used for anything in rpm so there's not even backward compatibility to care about. So the question becomes why do we appear to have (some) support for those unused algorithms? So lets don't, problem solved...
Agreed - and gone: ff4b911 Which makes this PR moot, but thanks for raising the point. |
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Mar 31, 2019
openssl support has been added in version 4.14.0 with rpm-software-management/rpm@64028f9 Add a patch from upstream to fix build with openssl ad MD2 is disabled by default: rpm-software-management/rpm#453 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MD2 is disabled by default in OpenSSL.