Python generators: Use nonstandardlib for purelib definition #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purelib and platlib were both defined to /usr/lib64/python on
64bits systems. This is because:
>>> get_python_lib(standard_lib=1, plat_specific=0)
'/usr/lib64/python3.7'
>>> get_python_lib(standard_lib=1, plat_specific=1)
'/usr/lib64/python3.7'
>>> get_python_lib(standard_lib=0, plat_specific=0)
'/usr/lib/python3.7/site-packages'
>>> get_python_lib(standard_lib=0, plat_specific=1)
'/usr/lib64/python3.7/site-packages'
So now we use standard_lib=0 to get the site-packages base path
from /usr/lib and not /usr/lib64.
Conan-Kudo
approved these changes
Jul 28, 2018
|
@hroncok This change looks good to me, but I'm actually a bit confused, what's the difference here between |
|
@hroncok Also, how does this affect Python 2? |
|
One has site-packages and zero does not. Yet all standard library is in lib64, hence this results. Will check legacy Python as well. |
$ python2.7
Python 2.7.15 (default, May 16 2018, 17:50:09)
[GCC 8.1.1 20180502 (Red Hat 8.1.1-1)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from distutils.sysconfig import get_python_lib
>>> from sys import version
>>> get_python_lib(standard_lib=1, plat_specific=0)
'/usr/lib64/python2.7'
>>> get_python_lib(standard_lib=1, plat_specific=1)
'/usr/lib64/python2.7'
>>> get_python_lib(standard_lib=0, plat_specific=0)
'/usr/lib/python2.7/site-packages'
>>> get_python_lib(standard_lib=0, plat_specific=1)
'/usr/lib64/python2.7/site-packages' |
|
Then it still looks good to me. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purelib and platlib were both defined to /usr/lib64/python on 64bits systems. This is because:
So now we use standard_lib=0 to get the site-packages base path from /usr/lib and not /usr/lib64.
See https://bugzilla.redhat.com/show_bug.cgi?id=1609492
And https://src.fedoraproject.org/rpms/python-rpm-generators/pull-request/2