Make list of dependencies in test/README consistent #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can see your point, but the rationale (nor the change) isn't quite right: this is an upstream document and not specific to any distros. Which means we should refer to dependencies by their upstream names: gpg2 is really just gnupg >= 2.0. While at it, python-rpm being on that list isn't right either. Firstly, you don't need such a dependency installed, you just need to build rpm with that support, and even that is no longer true since commit b3d3bc4 |
Thanks to Panu for pointing out that python-rpm should not been on the list.
|
Trivial as this change may be, the commit message is not really helpful as it completely fails to tell the actual story. The rationale(s) behind a change belongs to the commit message, not here in GH discussion. |
|
Addressed in commit f59bbff along with other improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other entries in the list of dependencies are names of provides. But gpg2 is name of executable and the command is not in package gpg2 or in a package with gpg2 in provides.