Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify build-script running to always use rpmfcExec() #659

Closed
wants to merge 2 commits into from

Conversation

pmatilai
Copy link
Member

@pmatilai pmatilai commented Apr 8, 2019

Simplifies the code and could be of use to PR #593

The downside is that it eats more memory due to buffering the entire build output but whether that matters... and could be conditionalized of course.

@pmatilai pmatilai mentioned this pull request Apr 8, 2019
26 tasks
@ffesti
Copy link
Contributor

ffesti commented Apr 9, 2019

I wonder if we want something even more generic that allows to pass stdin, stdout and stderr as stringbuffers and fdup also both stdout and stderr.
It would allow passing NULL for any of these. That way we would not use more memory if not needed.

@pmatilai
Copy link
Member Author

pmatilai commented Apr 9, 2019

Yeah I thought about the same thing, passing NULL as the buffer should mean not to buffer it at all.
Capturing stderr requires bigger changes though, as getOutputFrom() is only equipped to grab stdout now.

So this doesn't really make sense as it is now.

@pmatilai
Copy link
Member Author

Merged in slightly different form as part of #670

@pmatilai pmatilai closed this Apr 18, 2019
@pmatilai pmatilai deleted the rpmfcout-pr branch April 18, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants