Use --dpbath only with full path (RhBug:1696408) #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the patch rpm treats the relative path as a full path. The new behavior is similar to the "--root" option.
pmatilai
approved these changes
Apr 24, 2019
There was a problem hiding this comment.
I was about to mumble about using the same code for validating this and --root so both benefit in case we ever decide to use something more elaborate than just testing for / but --root is actually handled in rpmqv.c, which is wrong because --root is supported for all our tools.
Which is a long-winded way of saying that this is the right way to do it, and --root should be fixed instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the patch rpm treats the relative path as a full path.
The new behavior is similar to the "--root" option.