Only switch to userns-root if we actually need it for chroot() #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"userns-root" in the patch description looks like a typo. arg obviously ns stands for name space... |
|
Hmm, it's not a typo, it refers both to the chroot and root user inside the user namespace. |
|
I can certainly clarify it though. |
Since we don't have proper user/group info inside the user namespace we set up, avoid going there unless we have to. Fixes a regression introduced in commit b4c832c where non-root, non-chroot verification shows user and group differing on all files.
pmatilai
force-pushed
the
userns-rootdir-pr
branch
from
d1ddd7d
to
5d61e7c
Compare
|
Commit message updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't have proper user/group info inside userns-root, avoid
going there unless we have to. Fixes a regression introduced in
commit b4c832c where non-root,
non-chroot verification shows user and group differing on all files.