Fixes to rpmlib(DynamicBuildrequires) dependencies #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packages can never provide rpmlib() capabilities, don't pollute the namespace with invalid (if mostly harmless) data. The use-case of identifying whether there are dynamically generated buildrequires in an src.rpm is satisfied by looking for RPMSENSE_FIND_REQUIRES type requires as of commit bee5dc9.
rpmlib() dependencies are an install-time barrier, but dependencies in src.rpm are considered build-time dependencies. This paradox is the crux of the problem in https://pagure.io/copr/copr/issue/1038. We could move the rpmlib(DynamicBuildRequires) someplace else (eg buildrecommends) to avoid the issue, but then the dependency has technically every right to be there, and changing it would break existing software (mock) relying on what we already released. Adding MISSINGOK flag allows rpm to legitimately skip it while installing, the build-side does its own checking independently. This is not ideal as it requires backporting of commit 1ac1661 to older releases to fix, but this is the least-worst compromise we were able to come up with.
|
The downside is that old releases don't honor RPMSENSE_MISSINGOK in src.rpm rpmlib() checking, that two-liner patch needs to be backported to relevant releases. OTOH, rpm2cpio can always be used to extract contents so nobody is held hostage. As noted in the commits, this is just the least-worst compromise we could come up with. |
|
This looks like a good solution - especially if we backport the RPMSENSE_MISSINGOK change to older version. |
Conan-Kudo
approved these changes
Oct 25, 2019
|
Okay, so shall it be then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in the commit messages, executive summary:
This replaces the earlier PR #878. Original issue reported at https://pagure.io/copr/copr/issue/1038