Trying to upstream debian patches: Fix compilation on platforms without MAP_POPULATE

[KOLANICH]

https://salsa.debian.org/pkg-rpm-team/rpm/raw/master/debian/patches/map-populate.patch

[Conan-Kudo]

I feel like this patch is just asking for trouble. Given that it touches the debuginfo generation code, I'm not terribly comfortable passing judgment here.

[ignatenkobrain]

from what I have read in the documentation, MAP_POPULATE will just speed-up things. So if anybody will use this patch anyway, I think this desserves some better commit message and just be merged.

That said, I am not sure if I am right :)

[KOLANICH]

I think this desserves some better commit message

I have just preserved the message present in the patch. BTW, it LGTM. How do you propose to change it?

[pmatilai]

How do you propose to change it?

Just note that MAP_POPULATE is safe to drop in this manner as it's only an optimization, so future generations won't need to chase it down.

[Conan-Kudo]

@KOLANICH Here's a suggestion:

$ git commit --amend --author="Michal Čihař <nijel@debian.org>" --date="Sat, 11 Nov 2017 14:27:10 +0100"

With the following commit message:

tools/sepdebugcrcfix: Conditionally use MAP_POPULATE with mmap()

Not all architectures offer MAP_POPULATE. As MAP_POPULATE is only an
optimization to improve performance, it is safe to drop it when it is
unavailable.

[pmatilai]

Merged via #1006 . Thanks for the effort of bringing this upstream.

[KOLANICH]

Thanks.