Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brp-compress: Handle zstd compressed man/info pages #997

Merged
merged 1 commit into from Jan 10, 2020

Conversation

berolinux
Copy link
Contributor

Handle zstd compressed man/info pages in brp-compress

Signed-off-by: Bernhard Rosenkränzer bero@lindev.ch

@Conan-Kudo
Copy link
Member

Conan-Kudo commented Jan 7, 2020

@ignatenkobrain @pmatilai It seems like the tests are choking on python binary missing?

+/opt/rpm/tests/rpmtests.dir/at-groups/398/test-source: line 70: python: command not found

We probably need to request /usr/bin/python to be installed now...

@pmatilai
Copy link
Member

pmatilai commented Jan 7, 2020

We probably need to request /usr/bin/python to be installed now...

Nah. What @berolinux needs to do is rebase his tree: https://github.com/berolinux/rpm says:
"This branch is 633 commits behind rpm-software-management:master. "

@Conan-Kudo
Copy link
Member

Welp! 🐙

Handle zstd compressed man/info pages in brp-compress

Signed-off-by: Bernhard Rosenkränzer <bero@lindev.ch>
@berolinux
Copy link
Contributor Author

rebased

Copy link
Member

@Conan-Kudo Conan-Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and tests pass! :)

@pmatilai
Copy link
Member

Yup, much better now :)
Thanks for the patch!

@pmatilai pmatilai merged commit 0eb41c1 into rpm-software-management:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants