Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"communication not allowed" error in the wrong format and has no explanation #1008

Closed
farchord opened this issue Feb 24, 2023 · 6 comments
Closed

Comments

@farchord
Copy link

farchord commented Feb 24, 2023

Building a package for Fedora gives the following error:

kde-inotify-survey.x86_64: E: communication not allowed /usr/share/dbus-1/system.d/org.kde.kded.inotify.conf

The error message is inconsistent with normal rpmlint errors (format-wise) and has no explanation.

Thanks!

@marxin
Copy link
Contributor

marxin commented Feb 24, 2023

Confirmed, you are right. I'm going to prepare a patch. When it comes to the explanation, I will likely need a help from @mgerstner. Am I right that it tells that there's no D-Bus rule that would allow a sending?

@marxin
Copy link
Contributor

marxin commented Feb 27, 2023

I'm going to change the check name in #1009 and I'm going to leave this issue for future improvement of the missing description text.

@mgerstner
Copy link
Contributor

Yes it means that no one is allowed to talk to the service in question. Except root maybe?

This check is not part of the security related restrictions that we redesigned, it's general quality assurance. Adding a descriptive long description can be considered.

@marxin
Copy link
Contributor

marxin commented Feb 27, 2023

Adding a descriptive long description can be considered.

Can you (or anybody familiar enough with D-Bus) do that, please?

@farchord
Copy link
Author

farchord commented Feb 27, 2023

Not sure if it helps, but this is the content of the file in question that triggered that error:

<!DOCTYPE busconfig PUBLIC
 "-//freedesktop//DTD D-BUS Bus Configuration 1.0//EN"
 "http://www.freedesktop.org/standards/dbus/1.0/busconfig.dtd">
<busconfig>
 
  <!-- Only user root can own the foo helper -->
  <policy user="root">
    <allow own="org.kde.kded.inotify"/>
  </policy>
 
</busconfig>

mgerstner added a commit to mgerstner/rpmlint that referenced this issue Feb 27, 2023
For some reason the already existing dbus-policy-missing-allow in the
descriptions was not used before in DbusPolicyCheck. Harmonize that.

Closes rpm-software-management#1008
@mgerstner
Copy link
Contributor

It turns out there already was a description for this situation, only the error name was/is still not matching. Not sure how that happened, probably during the migration from the old rpmlint-checks repository.

@marxin marxin closed this as completed in bddb325 Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants