-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate metadata from setup.py to pyproject.toml #1019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I've been testing and it generates almost the same wheel package. The only thing that differ is the License and the Readme inclusion in the metadata file.
About the license, we discussed this in in the issue, but looking at the generated package, maybe it's better to keep the license info as text and just add the license-files
entry in the tools.setuptools
group.
This raises the minimum version of setuptools though, doesn't it? I don't think pyproject data for setuptools has been around that long. |
Yes, I didn't see that, maybe v61.0.0 is the minimum version required to have the pyproject.toml configuration file working. |
Then a setup dependency needs to be declared. |
There's a conflict in |
migrated the metadata from setup.py to pyproject.toml following the recommendation from setuptools docs. resolve: rpm-software-management#1012
added "rpmlint.descriptions" to packages metadata on pyproject.toml
altered the setuptools minimum version from 39.2 to 61.0, also changed the license to text and created the `license-files` on `tool.setuptools` table for declare the file of the license
Looks good to me, I've been testing and this produces almost the same |
Related to #1012. According to the recommendation of the setuptools docs the metadata was migrated from setup.py to pyproject.toml in order to maintain the setup.py with the minimal configuration.