Swap layout: Fall back to next layout - #3
Merged
Conversation
Owner
|
Yeah, I like that, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pick the next layout (as fallback) when the user performs
layout swapbut a last layout is not yet definedWhen I start a new
a4session and try to toggle/swap the layout (layout swap/C-a Tab) before I have switched the layout explicitly (for example vialayout fullscreen/C-a f), nothing happens. Whilea4can't know which layout I actually wanted to switch to, it's certain that I wanted to get a different layout.With this pull request, the next layout (
layout +1) gets activated as a fallback.(Personally, I would prefer to set the fullscreen layout in such a case. But this would be a bad choice if the user has removed the fullscreen layout in the a4 config file.)
@rpmohn : Just decline if you don't like such a behavior. Then at least other users will find this patch when they search for it.