Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup code + minor bug fixes #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

fraimondo
Copy link

We are currently working on a research project that uses neuroHarmonize. By digging into it, we found that some issues with the code that we address in this PR:

Summary of changes:

  • Fix unused imports.
  • Fix bug with setting random seed in harmonizationLearn.
  • Fix logic to avoid warnings due to unbound variables.
  • Format code to match black.
  • Add nibabel as an optional dependency.
  • Migrate to pyproject.toml.
  • Update installation instructions.
  • Update package build and publish instructions.

@rpomponio
Copy link
Owner

rpomponio commented Oct 21, 2022

Hi @fraimondo,

I appreciate you submitting this pull request. It may take me some time to review these commits. Some colleagues of mine have been working in-parallel on other commits (#28), so I'll have to resolve conflicts between the two branches.

I hope you have found this package helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants