Update scripts to account for new SITES #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melhemr
force-pushed
the
site_effects
branch
2 times, most recently
from
67d715a
to
7035f30
Compare
melhemr
force-pushed
the
site_effects
branch
2 times, most recently
from
16c6444
to
c1aa49d
Compare
|
@AbdulkadirA and @rpomponio can you review the changes we've made and merge if you think this is ready |
|
Awesome work, @melhemr ! The code looks good to me. Though I'm wondering what additional functionality this accomplishes. Is it the ability to apply the model to new, unseen sites? If @AbdulkadirA is on board with this, I'm happy to merge right away. |
|
@rpomponio I am on board with this. And yes, it enables to predict the standardized mean from external data. |
|
Awesome, I just merged and I am going to update the version number. |
|
Thank you so much Ray! I'm glad I could contribute to the project!
…________________________________
From: Raymond Pomponio ***@***.***>
Sent: Tuesday, July 20, 2021 12:20 PM
To: rpomponio/neuroHarmonize ***@***.***>
Cc: Melhem, Randa <Randa.Melhem@Pennmedicine.upenn.edu>; Mention ***@***.***>
Subject: [External] Re: [rpomponio/neuroHarmonize] Update scripts to account for new SITES (#9)
Awesome, I just merged and I am going to update the version number.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#9 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATRQL4IPK5UIPFKOLDGSNV3TYWO5HANCNFSM44W3VQ6A>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.