Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatability with Rails 5.2's ActiveModel::Dirty #19

Merged
merged 9 commits into from
Dec 20, 2018
Merged

Compatability with Rails 5.2's ActiveModel::Dirty #19

merged 9 commits into from
Dec 20, 2018

Commits on Dec 19, 2018

  1. Raise ruby version

    @garettarrowood
    garettarrowood committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    f74f02f View commit details
    Browse the repository at this point in the history

  2. Test updated Ruby versions

    @garettarrowood
    garettarrowood committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    44d85c3 View commit details
    Browse the repository at this point in the history

  3. Add gemfiles

    @garettarrowood
    garettarrowood committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    29c63ad View commit details
    Browse the repository at this point in the history

  4. Move development dependencies into gemspec

    @garettarrowood
    garettarrowood committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    fe721e5 View commit details
    Browse the repository at this point in the history

  5. Remove stackprof 

    jruby could not install this development dependency. And that is all it is, stackprof is a call-stack profiler. Not crucial to successful builds and can be added again by someone who may intend to use it.
    @garettarrowood
    garettarrowood committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    f6d951f View commit details
    Browse the repository at this point in the history

  6. Support only actively supported Ruby/Rails

    @benlangfeld
    benlangfeld committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    6fb177a View commit details
    Browse the repository at this point in the history

  7. Compatability with Rails 5.2's ActiveModel::Dirty 

    * We're now expected to call `#reset_changes`, rather than manipulating `@changed_attributes` directly.
* `ActiveRecord::Dirty` now assumes that any object it's included in which has an `@attributes` instance variable is database-backed, and has very specific API requirements for `@attributes` (must be an array of  `ActiveModel::Attribute` instances). This conflicts with modis' `@attributes`, so we trivially renamed this to `@modis_attributes` to distinguish them.
    @benlangfeld
    benlangfeld committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    b6118a0 View commit details
    Browse the repository at this point in the history

  8. Update changelog

    @benlangfeld
    benlangfeld committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    e5f2f87 View commit details
    Browse the repository at this point in the history

  9. Enforce minimum Ruby/Rails version support

    @benlangfeld
    benlangfeld committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    e4694da View commit details
    Browse the repository at this point in the history