Compatability with Rails 5.2's ActiveModel::Dirty #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jruby could not install this development dependency. And that is all it is, stackprof is a call-stack profiler. Not crucial to successful builds and can be added again by someone who may intend to use it.
This was referenced Dec 19, 2018
Closed
* We're now expected to call `#reset_changes`, rather than manipulating `@changed_attributes` directly. * `ActiveRecord::Dirty` now assumes that any object it's included in which has an `@attributes` instance variable is database-backed, and has very specific API requirements for `@attributes` (must be an array of `ActiveModel::Attribute` instances). This conflicts with modis' `@attributes`, so we trivially renamed this to `@modis_attributes` to distinguish them.
benlangfeld
force-pushed
the
rails-5-2
branch
from
1c70188
to
b6118a0
Compare
|
I incorporated #18, along with my suggestion for support (only actively supported Ruby and Rails versions) into this PR for ease of merging. |
garettarrowood
approved these changes
Dec 19, 2018
|
@ileitch @Tonkpils - I will merge this in a few hours unless I hear otherwise from one of you. However, I am not an owner and will now be able to cut a new release with the upgrade. A Otherwise, perhaps @aried3r , who looks to have push rights, can assist? I believe this change will make |
|
@garettarrowood I'll add you, what's your rubygems.org email address? |
|
It's garettarrowood@gmail.com . Thanks @ileitch ! |
|
@garettarrowood Done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#reset_changes, rather than manipulating@changed_attributesdirectly.ActiveRecord::Dirtynow assumes that any object it's included in which has an@attributesinstance variable is database-backed, and has very specific API requirements for@attributes(must be an array ofActiveModel::Attributeinstances). This conflicts with modis'@attributes, so we trivially renamed this to@modis_attributesto distinguish them.