Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings #30

Merged
merged 4 commits into from
Jul 7, 2020
Merged

Fix deprecation warnings #30

merged 4 commits into from
Jul 7, 2020

Conversation

rofreg
Copy link
Contributor

@rofreg rofreg commented Jun 25, 2020

I believe this fixes all deprecation warnings when running with:

  • latest redis gem
  • latest activemodel gem
  • latest Ruby (2.7.1)

You can reproduce these deprecation warnings by cloning the current repo, changing .ruby-version to 2.7.1, and running bundle exec rspec.

Also replaces #29 (bumping activesupport for a security update).

@aried3r
Copy link
Member

aried3r commented Jun 30, 2020

Please add a changelog entry. I will then merge and try to release a new version soon. Thanks!

@rofreg
Copy link
Contributor Author

rofreg commented Jun 30, 2020

Updated. Thank you for maintaining this gem, @aried3r! 🙂

@aried3r
Copy link
Member

aried3r commented Jul 6, 2020

Hey! I took another look and I believe at least in the specs we should either leave the update_attributes(!) specs or make sure that update_attributes(!) is just an alias to update(!).

They were added here #27 and right now in this PR I believe we're duplicating specs and not actually testing the old methods anymore.

@aried3r
Copy link
Member

aried3r commented Jul 6, 2020

That being said, I don't mind releasing a 4.x which removes the deprecated methods.

@rofreg
Copy link
Contributor Author

rofreg commented Jul 7, 2020

Good catch, thank you! I've removed the original commit that updated the update_attributes! tests, and appended a new commit that merely silences the deprecation warnings while still running the same tests. (As you say, the gem should still test that the deprecated methods work, and they SHOULD raise deprecation warnings when they get called!)

@aried3r
Copy link
Member

aried3r commented Jul 7, 2020

Awesome, thanks!

@aried3r aried3r merged commit 12b9c44 into rpush:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants