Add missing #update and #update! persistance methods
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment we are just supporting `#update_attributes` and `#update_attributes!` to update records. Those methods have been aliased in ActiveRecord for years, and finally will be removed in the next version - Rails 6.1.
garettarrowood
approved these changes
Dec 11, 2019
|
The CI failures were caused by this, which is now fixed. ruby/json#392 (comment) I restarted the failing jobs and now everything seems to be in order. Thanks for the contribution! |
|
Released as 3.2.0. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to fix some deprecation warning in Rpush - rpush/rpush#541, we realized that we are not following the same API than ActiveRecord.
At the moment we are just supporting
#update_attributesand#update_attributes!to update records. Those methods have been aliased in ActiveRecord for years, and finally will be removed in the next version - Rails 6.1.To don't break the current API, we are aliasing the deprecated methods with the new naming, and adding a warning that explains the replacement.