Switch GCM with FCM server endpoint #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests with Rubinius seem to fail because of an error with Travis-CI itself: travis-ci/travis-ci#5294 |
I purposedly left all comments, classes, debug output etc untouched, because other than the server endpoint, users of the library still use GCM and not FCM. Renaming everything would break the API and thus require a version 3. For reference, see: https://developers.google.com/cloud-messaging/android/android-migrate-fcm#update_server_endpoints
aried3r
force-pushed
the
ar/fcm_endpoint
branch
from
1f17052
to
f6634d9
Compare
|
Friendly ping @amaierhofer, would you mind taking a look? :) |
|
Merging in good faith that you have verified it does send via the new endpoint :) I believe we should ignore rbx on travis for now, I believe adaption rates are low |
|
so I am wondering, if i use the documented way for implementing gcm to implement fcm. It will work because of the change of the endpoint? |
|
@jaz5hq Would have worked even without the endpoint change ;) |
Adrian1707
pushed a commit
to Adrian1707/rpush
that referenced
this pull request
Apr 24, 2024
Switch GCM with FCM server endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I purposedly left all comments, classes, debug output etc untouched,
because other than the server endpoint, users of the library still use
GCM and not FCM.
Renaming everything would break the API and thus require a version 3.
For reference, see:
https://developers.google.com/cloud-messaging/android/android-migrate-fcm#update_server_endpoints