Added support for P8 certificate apple push notifications #386
Conversation
# Conflicts: # lib/generators/rpush_migration_generator.rb
| @@ -14,3 +14,4 @@ def self.down | |||
| drop_table :rapns_apps | |||
| end | |||
| end | |||
| x | |||
There was a problem hiding this comment.
I guess this was mistakenly added here?
README.md
Outdated
| ```ruby | ||
| app = Rpush::Apnsp8::App.new | ||
| app.name = "ios_app" | ||
| app.apn_key = File.read("/path/to/sandbox.pem") |
|
Thanks for your PR! Sadly I cannot test this myself as I don't use APNS myself, but I'll try to have a closer look soon. |
|
@mariannegru could you please provide more information in description for this PR, e.g. Apple links to what is P8 and how to generate it. Will be useful for testing. thanks! |
|
I can test this, because I need APNS token support |
* upstream/master: Prepare 3.0.2 release Add 3.0.1 migration to test suite use actual table name Prepare 3.0.1 release Update dependencies Add changelog for 3.0.1 Update rubies # Conflicts: # spec/support/active_record_setup.rb
|
@mariannegru Good job. I am testing it right now. Got |
|
@sveredyuk Can you check in sql if the apn_key is set? Must be something with You need to make sure you have all the values present: apn_key, apn_key_id ,team_id, bundle_id I use fastlane to generate p8 files. |
|
Yes, apn_key is present and valid (i got it from apple dev site), JWT token is generating but response |
|
Are you testing development or production? Maybe the device token is not for the right environment. |
|
for production, we are using production env even on staging devices |
|
If you run the app from xcode I think you should use the development environment and make sure you have the rpush app configured for development. We have it for 46 apps in production and is working fine. |
|
Hey @mariannegru. What's holding this PR from being merged into master? |
|
I think it should be rebased once more to see if the issues with CI were fixed in I'd rather have more people try out this feature as "experimental" than rely on people manually trying out this branch. |
* upstream/master: fixes rpush#416 @notification.app triggers loading of association :app Add Gemfile.lock to .gitignore Use newest modis and rpush-modis Add newly generated gemfiles Limit pg gem for some test setups Remove Gemfile.lock Update .travis.yml to test using Ruby 2.5 Add sandbox URL to ApnsHttp2 dispatcher
|
We are waiting for this MR to be merged. I could test it again |
|
@sveredyuk did you tested this again? |
|
@mariannegru just planed to test on weekend. |
|
Hey! Sorry for the long silence. I am currently preparing a 3.1.0 release and will try to tackle this next for a 3.2.0. Unfortunately there are now some (expected) conflicts. If I find the time I'll try to resolve them myself, but I'd appreciate any help. One thing that would have to be changed is the name of the migration ( |
* upstream/master: Add some info about the auth_key Update CHANGELOG.md Update CHANGELOG.md Re-add Gemfile.lock to repo. Fixes rpush#425 Prepare 3.1.1 release Use latest gem release on Travis Add changelog entry [ci skip] Changed pluck(:id) to .ids rpush_notifications active_record performance improvements Prepare 3.1.0 release Update CHANGELOG.md [ci skip] Add support for Pushy service # Conflicts: # lib/generators/rpush_migration_generator.rb # lib/rpush/client/redis/app.rb # spec/support/active_record_setup.rb
|
@aried3r Sorry for the delay, I've merged the latest and renamed to migrations to the next release |
|
Awesome! Thank you, I'll have another look and hope to merge it soon when I get the time. |
Added support for P8 certificate apple push notifications
Apple push notifications using authentication tokens
http://help.apple.com/xcode/mac/current/#/dev54d690a66