Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings from the redis gem #636

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

sharang-d
Copy link
Contributor

Fixes these warnings introduced in Redis 4.6.0

Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

redis.multi do
  redis.get("key")
end

should be replaced by

redis.multi do |pipeline|
  pipeline.get("key")
end

(called from /bundle_path/ruby/3.0.0/gems/rpush-7.0.0/lib/rpush/daemon/store/redis.rb:170:in `block in pending_notification_ids'}

Similar commit in sidekiq: sidekiq/sidekiq@c792342

@aried3r
Copy link
Member

aried3r commented Mar 2, 2022

Looks good to me, thank you!

@aried3r aried3r merged commit c0da089 into rpush:master Mar 2, 2022
Adrian1707 pushed a commit to Adrian1707/rpush that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants