Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RQLITE_HISTFILESIZE=0 still writes an .rqlite_history file #1145

Closed
jamielinux opened this issue Jan 3, 2023 · 3 comments · Fixed by #1146
Closed

RQLITE_HISTFILESIZE=0 still writes an .rqlite_history file #1145

jamielinux opened this issue Jan 3, 2023 · 3 comments · Fixed by #1146

Comments

@jamielinux
Copy link

jamielinux commented Jan 3, 2023

What version are you running?

Version v7.13.0, commit f4a1583d3a63e55ddc7d310c64d8a6cd0a0f2b1d, branch master, built on 2022-12-15T11:04:54-0500

Are you using Docker or Kubernetes to run your system?

No.

Are you running a single node or a cluster?

3-node cluster.

What did you do?

Set RQLITE_HISTFILESIZE=0 in the shell environment.

What did you expect to happen?

No .rqlite_history file created.

What happened instead?

An empty (zero-byte) .rqlite_history file was created.

Obviously this isn't a massive issue, but I think it'd be better if it doesn't create an empty file when you set the size to zero.

Thank you!

@otoolep
Copy link
Member

otoolep commented Jan 4, 2023

Thanks for the report @jamielinux

@jamielinux
Copy link
Author

Thank you @otoolep for already creating a PR!

otoolep added a commit that referenced this issue Jan 4, 2023
Delete history file if RQLITE_HISTFILESIZE is zero

Fixes #1145.
@otoolep
Copy link
Member

otoolep commented Jan 7, 2023

Fixed in 7.13.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants