Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore explicit join request if there is preexisting state #1135

Merged
merged 9 commits into from
Dec 4, 2022

Conversation

otoolep
Copy link
Member

@otoolep otoolep commented Dec 2, 2022

No description provided.

@otoolep
Copy link
Member Author

otoolep commented Dec 2, 2022

Test fails because there is a need to join if ID or address changes. Perhaps the bug is to ignore self-joins. But is that an error? Scenario may be: 3-node cluster. Kill leader. Node 2 becomes leader, then restart it with same command line params. It will try to join itself, it it comes back up as leader.

@otoolep otoolep merged commit bc29750 into master Dec 4, 2022
@otoolep otoolep deleted the ignore-join-explicit-if-state branch December 4, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant