Synchronize Snapshotting and chunked loading #1463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With chunked loads, a snapshot will delete "LOAD_CHUNK" entries from the Raft log. However those entries may have not been committed to the database yet, it won't happen until the last chunk is received. This would be OK, unless the system restarted before the last chunk and then the those entries would be lost, but the database not updated -- or worse, updated with an incomplete load operation (which would result in a invalid SQLite file).