Use Go standard libary sql/database abstraction #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds.
Empty statements now cause panic.
No longer relevant since each Exec and Query gets its own connection.
BoltDB has run fine for years with this issues, continue to ignore them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the DB layer such that it no longer uses the SQLite driver directly, but instead uses the Go standard library SQL abstraction. This was done to fix faulty SQLite connection handling, in the context of multiple goroutines. This is believed to be the root cause of #830
Using the standard library abstraction also brings in connection pooling, which should help with some concurrency improvements -- without bugs. Connection pool stats are also added to the status/ output.