Compress storage data on NetPlay #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compresses Magic Storage data before transmitting (and decompresses before receiving) them during multiplayer. This is not a sure nor a correct fix for blushiemagic#47 and blushiemagic#41 but delays them from occurring (if you place an extra massive amount of items into the storage it'll still happen again) while also improving network performance, true reason I'm posting. Data is compressed on a 10:2 ratio average (allowing you to store up to about 5 times the amount of items before the above bug recur). Example of some storage units, all upgraded to Luminite, during a heavily modded run (in bytes): Magic Storage Data Compression Stats: 12014 => 2806 Magic Storage Data Compression Stats: 19412 => 3890 Magic Storage Data Compression Stats: 18932 => 3837 Magic Storage Data Compression Stats: 18476 => 3470 Magic Storage Data Compression Stats: 18896 => 3561 I left the compression stats code in but disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compresses Magic Storage data before transmitting (and decompresses before receiving) them during multiplayer.
This is not a sure nor a correct fix for blushiemagic#47 and blushiemagic#41 but delays them from occurring (if you place an extra massive amount of items into the storage it'll still happen again) while also improving network performance, true reason I'm posting. Data is compressed on a 10:2 ratio average (allowing you to store up to about 5 times the amount of items before the above bug recur). Example of some storage units, all upgraded to Luminite, during a heavily modded run (in bytes):
Magic Storage Data Compression Stats: 12014 => 2806
Magic Storage Data Compression Stats: 19412 => 3890
Magic Storage Data Compression Stats: 18932 => 3837
Magic Storage Data Compression Stats: 18476 => 3470
Magic Storage Data Compression Stats: 18896 => 3561
I left the compression stats code in but disabled.