Mimic React Hook's dependencies comparison #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #374 +/- ##
==========================================
- Coverage 99.87% 99.87% -0.01%
==========================================
Files 18 18
Lines 804 781 -23
==========================================
- Hits 803 780 -23
Misses 1 1
☔ View full report in Codecov by Sentry. |
rrousselGit
reviewed
Jul 21, 2023
| @@ -172,7 +172,23 @@ Calling them outside of build method leads to an unstable state and is therefore | |||
| if (!i1.moveNext() || !i2.moveNext()) { | |||
| return true; | |||
| } | |||
| if (i1.current != i2.current) { | |||
|
|
|||
There was a problem hiding this comment.
The docs need to be updated to match
|
LGTM, with a tiny bit of documentation needed Could you also add a changelog? |
|
Documenting has been done! You might wanna resolve the |
rrousselGit
reviewed
Jul 25, 2023
|
Looking good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#155
This PR changes the comparison behavior to mimic the React Hook dependencies comparison which uses
Object.is().Previously,
keysare compared by the==operator. The Dart==operator works differently from the JavaScriptObject.is():Object.is()
Dart ==
This PR checks if a list of
keyscontain a value with the typenumand proceeds to handle cases where the value is eitherNaNor0.0and-0.0.