-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SearchAnchor
test for pending timer
#422
Update SearchAnchor
test for pending timer
#422
Conversation
|
@@ -71,6 +71,8 @@ void main() { | |||
controller.openView(); | |||
|
|||
expect(controller.isOpen, true); | |||
// Advance fade animation duration. | |||
await tester.pumpAndSettle(const Duration(seconds: 150)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this change. I'm not testing animations here. Why would this be needed?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #422 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 21 21
Lines 858 858
=======================================
Hits 844 844
Misses 14 14 ☔ View full report in Codecov by Sentry. |
Me too. I didn't see another way but thanks to your suggestion flutter/flutter#143443, the change in the Flutter PR is no longer the failing the |
This PR fixes the pending timer when
SearchAnchor
is opened in the "check opening/closing view" test in theuse_search_controller_test.dart
class.Unblocks a Flutter bug fix as
flutter_hooks
tests are part of the Google Testing suite.