Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SearchAnchor test for pending timer #422

Closed

Conversation

TahaTesser
Copy link

This PR fixes the pending timer when SearchAnchor is opened in the "check opening/closing view" test in the use_search_controller_test.dart class.

Unblocks a Flutter bug fix as flutter_hooks tests are part of the Google Testing suite.

Copy link

changeset-bot bot commented Mar 19, 2024

⚠️ No Changeset found

Latest commit: 2733fc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -71,6 +71,8 @@ void main() {
controller.openView();

expect(controller.isOpen, true);
// Advance fade animation duration.
await tester.pumpAndSettle(const Duration(seconds: 150));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this change. I'm not testing animations here. Why would this be needed?

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (15fdb4f) to head (2733fc4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #422   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files          21       21           
  Lines         858      858           
=======================================
  Hits          844      844           
  Misses         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TahaTesser
Copy link
Author

TahaTesser commented Mar 19, 2024

I don't like this change. I'm not testing animations here. Why would this be needed?

Me too. I didn't see another way but thanks to your suggestion flutter/flutter#143443, the change in the Flutter PR is no longer the failing the flutter_hooks test, closing as a result.

@TahaTesser TahaTesser closed this Mar 19, 2024
@TahaTesser TahaTesser deleted the update_search_anchor_test branch March 19, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants