Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated JsonKey annotation for hashCode and copyWith #1104

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

lrsvmb
Copy link
Contributor

@lrsvmb lrsvmb commented Jul 8, 2024

Replaces old @JsonKey(ignore: true) annotations in *.freezed.dart files with @JsonKey(includeFromJson: false, includeToJson: false). This has been deprecated since json_serializable: ^6.6.0.

Closes #1043.

Local tests passing.

Copy link

changeset-bot bot commented Jul 8, 2024

⚠️ No Changeset found

Latest commit: 3fc2d52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rrousselGit
Copy link
Owner

Could you bump the minimum json_annotation version to 4.8.0 too?

@lrsvmb
Copy link
Contributor Author

lrsvmb commented Jul 8, 2024

Could you bump the minimum json_annotation version to 4.8.0 too?

Done 👍

@rrousselGit
Copy link
Owner

Awesome, thanks!

@rrousselGit rrousselGit merged commit 280a863 into rrousselGit:master Jul 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uses deprecated @JsonKey(ignore: true) annotation for copyWith and hashCode
2 participants