Upgrade to later analyzer package, which no longer support isUndefined
#67
Conversation
| // @todo should be `final void Function(T) a;` instead of | ||
| // `final void Function(dynamic) a;` | ||
| // and `DiagnosticsProperty<void Function(T)>` instead of | ||
| // `ObjectFlagProperty<dynamic>.has` | ||
| await _expect('typedefTest', completion(''' | ||
| class TypedefTest<T> extends StatelessWidget { | ||
| const TypedefTest(this.a, {Key key}) : super(key: key); | ||
|
|
||
| final void Function(dynamic) a; | ||
|
|
||
| @override | ||
| Widget build(BuildContext _context) => typedefTest<T>(a); | ||
| @override |
There was a problem hiding this comment.
functionally seems to be suboptimal, but at least for now it's still working for developer, and not crash due to https://github.com/rrousselGit/functional_widget/pull/67/files#diff-8725693a4d1b56a9253011b227f468ddL7 element.session being null.
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 4 3 -1
Lines 308 310 +2
=======================================
+ Hits 307 309 +2
Misses 1 1
Continue to review full report at Codecov.
|
truongsinh
changed the title
analyzer package, which no longer suppert isUndefinedanalyzer package, which no longer support isUndefined
|
I really hate rounding and floating point number 😒 |
Co-authored-by: Remi Rousselet <darky12s@gmail.com>
|
@rrousselGit done upgrading dependencies, though brace for big changes 😂 |
|
Haha thanks again for working on that! |
|
Looks good to me, thanks again! |
Close #55 Close #63 Close #64
I added several more unit test, one of which seems to be functionally incorrect, but at least it guards against the crash (due to null
element.session)