If dependencies is empty, add const #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2310 +/- ##
===========================================
+ Coverage 95.25% 100.00% +4.74%
===========================================
Files 53 3 -50
Lines 2253 74 -2179
===========================================
- Hits 2146 74 -2072
+ Misses 107 0 -107 |
rrousselGit
reviewed
Mar 13, 2023
|
|
||
| expect( | ||
| emptyDependenciesStatefulProvider.dependencies, | ||
| const <ProviderOrFamily>[], |
There was a problem hiding this comment.
Those tests would pass even without the const. Wrap the list in a "same()"
There was a problem hiding this comment.
I wrapped it with "same()"👍
rrousselGit
reviewed
Mar 13, 2023
| @@ -106,6 +106,18 @@ void main() { | |||
| transitiveDependenciesProvider.dependencies, | |||
| same(transitiveDependenciesProvider.dependencies), | |||
| ); | |||
| expect( | |||
| smallTransitiveDependencyCountProvider.dependencies, | |||
| same(smallTransitiveDependencyCountProvider.dependencies), | |||
There was a problem hiding this comment.
That's not what I meant
Do same(const <ProviderOrFamily>[])
There was a problem hiding this comment.
@rrousselGit I have responded to the comment you provided, and I would appreciate it if you could take a moment to review my response
|
LGTM, thanks a lot ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a provider with an empty list for dependencies, a warning was raised.
I fixed it by adding const.
https://dart-lang.github.io/linter/lints/prefer_const_literals_to_create_immutables.html