Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If dependencies is empty, add const #2310

Merged
merged 7 commits into from Apr 7, 2023
Merged

If dependencies is empty, add const #2310

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3141b8f
If dependencies is empty, add const
K9i-0 Mar 13, 2023
e27f111
simplify
K9i-0 Mar 13, 2023
cef6d9c
add cache test
K9i-0 Mar 13, 2023
87a14ca
wrap const
K9i-0 Mar 13, 2023
59c82e8
Changelog
rrousselGit Apr 7, 2023
dcb69f8
Merge branch 'master' of https://github.com/rrousselGit/riverpod into…
rrousselGit Apr 7, 2023
21b50a7
Update generated files
rrousselGit Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/riverpod_generator/test/dependencies_test.dart
View file
Open in desktop
Expand Up @@ -106,6 +106,18 @@ void main() {
transitiveDependenciesProvider.dependencies,
same(transitiveDependenciesProvider.dependencies),
);
expect(
smallTransitiveDependencyCountProvider.dependencies,
same(smallTransitiveDependencyCountProvider.dependencies),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not what I meant

Do same(const <ProviderOrFamily>[])

Copy link
Sponsor Contributor Author

@K9i-0 K9i-0 Mar 13, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Wrote the code this way in commit cef6d9c because it is a test to check if the dependencies are cached

In commit 87a14ca, I have incorporated the feedback

Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rrousselGit I have responded to the comment you provided, and I would appreciate it if you could take a moment to review my response

);
expect(
emptyDependenciesStatelessProvider.dependencies,
same(emptyDependenciesStatelessProvider.dependencies),
);
expect(
emptyDependenciesStatefulProvider.dependencies,
same(emptyDependenciesStatefulProvider.dependencies),
);

expect(
provider3Provider.allTransitiveDependencies,
Expand All @@ -119,5 +131,9 @@ void main() {
transitiveDependenciesProvider.allTransitiveDependencies,
same(transitiveDependenciesProvider.allTransitiveDependencies),
);
expect(
smallTransitiveDependencyCountProvider.allTransitiveDependencies,
same(smallTransitiveDependencyCountProvider.allTransitiveDependencies),
);
});
}