feat: allow ignoring module attributes in Credo.Check.Readability.StrictModuleLayout #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorbash
reviewed
Jun 13, 2023
|
@rrrene Sorry for the ping but is there anything I can do to get this reviewed and merged? I'm pretty sure GH was having issues when I submitted the PR and that's why the checks are all failing. |
rrrene
requested changes
Dec 19, 2023
|
Alright, checks are running again 👍 |
|
@btkostner Thx! Will be released for X-Mas 🎄 👍 |
|
@rrrene Awesome! Thank you for your work maintaining this awesome library 🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of libraries define custom attributes and DSLs that adjust code in the next function. This PR allows users to ignore specific attributes from the
Credo.Check.Readability.StrictModuleLayoutcheck. Documentation and tests included.Examples:
@decoratelibrary@tracelibraries