Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rrwebPlayer types #46

Merged
merged 1 commit into from
Oct 10, 2020
Merged

Update rrwebPlayer types #46

merged 1 commit into from
Oct 10, 2020

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Oct 9, 2020

Without this change, the following fails to compile in typescript:

new rrwebPlayer({
    target: document.body,
    props: {
        width: 900,
        events,
        autoPlay: true,
    },
})

Without this change, the following fails to compile in typescript:

```js
new rrwebPlayer({
                target: document.body,
                props: {
                    width: 900,
                    events,
                    autoPlay: true,
                },
            })
```
@Yuyz0112
Copy link
Member

Thanks!

@Yuyz0112 Yuyz0112 merged commit ea0ac76 into rrweb-io:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants