Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update puppeteer to 19.0.0 #1022

Closed
wants to merge 11 commits into from
Closed

Chore: Update puppeteer to 19.0.0 #1022

wants to merge 11 commits into from

Conversation

Juice10
Copy link
Contributor

@Juice10 Juice10 commented Oct 14, 2022

No description provided.

@Juice10 Juice10 changed the title Update puppeteer to 18.2.1 Chore: Update puppeteer to 18.2.1 Oct 14, 2022
@Juice10 Juice10 changed the title Chore: Update puppeteer to 18.2.1 Chore: Update puppeteer to 19.0.0 Oct 19, 2022
@Juice10 Juice10 marked this pull request as draft October 20, 2022 15:39
@eoghanmurray
Copy link
Contributor

I think this is stale.

I also hope to update further for rrweb (<iframe src="doc.pdf"> test case) after the following is fixed: puppeteer/puppeteer#12172

Would the 'vite' stuff mean that we can have one version of puppeteer for all projects?

Here's what I currently see:

$ git grep '"puppeteer":'
packages/rrdom-nodejs/package.json:    "puppeteer": "^9.1.1",
packages/rrdom/package.json:    "puppeteer": "^17.1.3",
packages/rrweb-snapshot/package.json:    "puppeteer": "^17.1.3",
packages/rrweb/package.json:    "puppeteer": "^20.9.0",

@Juice10
Copy link
Contributor Author

Juice10 commented Apr 8, 2024

I think this is stale.

Yes this PR is stale, thanks for closing.

I also hope to update further for rrweb (<iframe src="doc.pdf"> test case) after the following is fixed: puppeteer/puppeteer#12172

Would the 'vite' stuff mean that we can have one version of puppeteer for all projects?

Not really, but it'll make it easier to update this sort of thing across the board.

Here's what I currently see:


$ git grep '"puppeteer":'

packages/rrdom-nodejs/package.json:    "puppeteer": "^9.1.1",

packages/rrdom/package.json:    "puppeteer": "^17.1.3",

packages/rrweb-snapshot/package.json:    "puppeteer": "^17.1.3",

packages/rrweb/package.json:    "puppeteer": "^20.9.0",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants