Fix for test cases mentioned in #1379 #1401
Merged
+90
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1f0316c The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
|
got around to testing this against the test recording I created that has the thanks @dengelke ! - hopefully this can get into the queue for reviewing the solution 🤞 |
|
@dengelke can you add a changeset (see other comment above) and add the link of where you found the css parser to the code so we can keep track of where this came from if it ever needs updating? |
|
@Juice10 updated the changeset and added a comment in the code |
Juice10
approved these changes
Apr 18, 2024
eoghanmurray
added a commit
that referenced
this pull request
Apr 18, 2024
* better splitting of selectors - overlapping with #1401 * Add test from example at PostHog/posthog#21427 * ignore brackets inside selector strings * Add another test as noticed that it's possible to escape strings * Ensure we are ignoring commas within strings Co-authored-by: Eoghan Murray <eoghan@getthere.ie>
billyvg
pushed a commit
to getsentry/rrweb
that referenced
this pull request
Apr 19, 2024
* better splitting of selectors - overlapping with rrweb-io#1401 * Add test from example at PostHog/posthog#21427 * ignore brackets inside selector strings * Add another test as noticed that it's possible to escape strings * Ensure we are ignoring commas within strings Co-authored-by: Eoghan Murray <eoghan@getthere.ie>
billyvg
pushed a commit
to getsentry/rrweb
that referenced
this pull request
Apr 19, 2024
* better splitting of selectors - overlapping with rrweb-io#1401 * Add test from example at PostHog/posthog#21427 * ignore brackets inside selector strings * Add another test as noticed that it's possible to escape strings * Ensure we are ignoring commas within strings Co-authored-by: Eoghan Murray <eoghan@getthere.ie>
billyvg
pushed a commit
to getsentry/rrweb
that referenced
this pull request
Apr 19, 2024
* Fix known issues * Run format * Fix linting errors * Add comment in code for source of match logic * Add changeset
billyvg
pushed a commit
to getsentry/rrweb
that referenced
this pull request
Apr 19, 2024
* better splitting of selectors - overlapping with rrweb-io#1401 * Add test from example at PostHog/posthog#21427 * ignore brackets inside selector strings * Add another test as noticed that it's possible to escape strings * Ensure we are ignoring commas within strings Co-authored-by: Eoghan Murray <eoghan@getthere.ie>
billyvg
added a commit
to getsentry/rrweb
that referenced
this pull request
Apr 19, 2024
#169)" (#182) This reverts commit 810b39f. Reverting this in favor of rrweb-io#1401 and rrweb-io#1440 which is better than whatever it is I wrote. I kept our tests just to ensure the fix is compatible with our previous patch.
This was referenced Apr 24, 2024
jaj1014
pushed a commit
to pendo-io/rrweb
that referenced
this pull request
Apr 30, 2024
* Fix known issues * Run format * Fix linting errors * Add comment in code for source of match logic * Add changeset
jaj1014
pushed a commit
to pendo-io/rrweb
that referenced
this pull request
Apr 30, 2024
* better splitting of selectors - overlapping with rrweb-io#1401 * Add test from example at PostHog/posthog#21427 * ignore brackets inside selector strings * Add another test as noticed that it's possible to escape strings * Ensure we are ignoring commas within strings Co-authored-by: Eoghan Murray <eoghan@getthere.ie>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of parsing function using selector from here and update to logic for
,inside()and associated tests to fix #1379