Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building an offchain::ipfs app #9

Merged
merged 2 commits into from
Oct 20, 2020
Merged

Building an offchain::ipfs app #9

merged 2 commits into from
Oct 20, 2020

Conversation

aphelionz
Copy link
Contributor

@aphelionz aphelionz commented Oct 17, 2020

This PR reworks the "Building an offchain::ipfs app" section of the manual.

  • Updates the "Example Pallet" page
  • Moves the content from the "How it works" page to the section introduction
  • Updates the SUMMARY.md file with a suggestion of a new outline

Also includes the work that was previously in #7

@aphelionz aphelionz mentioned this pull request Oct 18, 2020
@aphelionz aphelionz changed the title Template Pallet Section Building an offchain::ipfs app Oct 18, 2020
src/template-pallet.md Outdated Show resolved Hide resolved
@aphelionz aphelionz marked this pull request as ready for review October 18, 2020 05:51
src/template-pallet.md Outdated Show resolved Hide resolved
src/template-pallet.md Outdated Show resolved Hide resolved
src/template-pallet.md Outdated Show resolved Hide resolved
@aphelionz aphelionz force-pushed the section/template-pallet branch 3 times, most recently from 887dcb1 to 4d3176e Compare October 20, 2020 03:20
Copy link
Member

@ljedrz ljedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course I left some comments as a review bulk instead of doing single comments 🤦

src/offchain-ipfs-callables.md Outdated Show resolved Hide resolved
src/offchain-ipfs-callables.md Outdated Show resolved Hide resolved
src/offchain-ipfs-callables.md Outdated Show resolved Hide resolved
src/offchain-ipfs-callables.md Outdated Show resolved Hide resolved
src/offchain-ipfs-callables.md Outdated Show resolved Hide resolved
src/template-pallet.md Outdated Show resolved Hide resolved
src/template-pallet.md Outdated Show resolved Hide resolved
src/offchain-ipfs-callables.md Outdated Show resolved Hide resolved
src/template-pallet.md Show resolved Hide resolved
src/template-pallet.md Show resolved Hide resolved
Co-authored-by: ljedrz <ljedrz@users.noreply.github.com>
Co-authored-by: whalelephant <whalelephant@users.noreply.github.com>

linting

Update src/offchain-ipfs-callables.md

Co-authored-by: ljedrz <ljedrz@users.noreply.github.com>

Update src/offchain-ipfs-callables.md

Co-authored-by: ljedrz <ljedrz@users.noreply.github.com>

Update src/offchain-ipfs-callables.md

Co-authored-by: ljedrz <ljedrz@users.noreply.github.com>

Update src/template-pallet.md

Co-authored-by: ljedrz <ljedrz@users.noreply.github.com>

Update src/template-pallet.md

Co-authored-by: ljedrz <ljedrz@users.noreply.github.com>

Update src/offchain-ipfs-callables.md

Co-authored-by: ljedrz <ljedrz@users.noreply.github.com>

Update src/template-pallet.md

Co-authored-by: bwty <email-me@belsy.space>

Update src/offchain-ipfs-callables.md

Co-authored-by: ljedrz <ljedrz@users.noreply.github.com>

more PR fixes
Co-authored-by: ljedrz <ljedrz@users.noreply.github.com>
Co-authored-by: whalelephant <whalelephant@users.noreply.github.com>
@aphelionz aphelionz merged commit 883f231 into main Oct 20, 2020
@aphelionz aphelionz deleted the section/template-pallet branch October 20, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants