-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building an offchain::ipfs app #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphelionz
force-pushed
the
section/template-pallet
branch
from
October 17, 2020 20:59
99fde2d
to
d869c9e
Compare
Closed
aphelionz
commented
Oct 18, 2020
aphelionz
commented
Oct 18, 2020
aphelionz
commented
Oct 18, 2020
aphelionz
commented
Oct 18, 2020
aphelionz
commented
Oct 18, 2020
aphelionz
commented
Oct 18, 2020
aphelionz
commented
Oct 18, 2020
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
aphelionz
force-pushed
the
section/template-pallet
branch
from
October 19, 2020 15:25
5c0ea11
to
41ea57f
Compare
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
ljedrz
reviewed
Oct 19, 2020
aphelionz
force-pushed
the
section/template-pallet
branch
3 times, most recently
from
October 20, 2020 03:20
887dcb1
to
4d3176e
Compare
ljedrz
reviewed
Oct 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course I left some comments as a review bulk instead of doing single comments 🤦
Co-authored-by: ljedrz <ljedrz@users.noreply.github.com> Co-authored-by: whalelephant <whalelephant@users.noreply.github.com> linting Update src/offchain-ipfs-callables.md Co-authored-by: ljedrz <ljedrz@users.noreply.github.com> Update src/offchain-ipfs-callables.md Co-authored-by: ljedrz <ljedrz@users.noreply.github.com> Update src/offchain-ipfs-callables.md Co-authored-by: ljedrz <ljedrz@users.noreply.github.com> Update src/template-pallet.md Co-authored-by: ljedrz <ljedrz@users.noreply.github.com> Update src/template-pallet.md Co-authored-by: ljedrz <ljedrz@users.noreply.github.com> Update src/offchain-ipfs-callables.md Co-authored-by: ljedrz <ljedrz@users.noreply.github.com> Update src/template-pallet.md Co-authored-by: bwty <email-me@belsy.space> Update src/offchain-ipfs-callables.md Co-authored-by: ljedrz <ljedrz@users.noreply.github.com> more PR fixes
aphelionz
force-pushed
the
section/template-pallet
branch
from
October 20, 2020 10:02
ab1f3b4
to
18fb4c2
Compare
Co-authored-by: ljedrz <ljedrz@users.noreply.github.com> Co-authored-by: whalelephant <whalelephant@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the "Building an
offchain::ipfs
app" section of the manual.Also includes the work that was previously in #7