Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DataSet.append() due to upcoming deprecation in Pandas #149

Merged
merged 2 commits into from
May 23, 2022

Conversation

JBGreisman
Copy link
Member

@JBGreisman JBGreisman commented May 19, 2022

This PR fixes #146 to remove the overloaded function, DataSet.append(), and any uses of it.

@JBGreisman JBGreisman added the API Interface Decisions label May 19, 2022
@JBGreisman JBGreisman requested a review from kmdalton May 19, 2022 19:56
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #149 (c040f92) into main (f7d2a2c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   98.46%   98.45%   -0.02%     
==========================================
  Files          43       43              
  Lines        1696     1681      -15     
==========================================
- Hits         1670     1655      -15     
  Misses         26       26              
Flag Coverage Δ
unittests 98.45% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
reciprocalspaceship/concat.py 100.00% <ø> (ø)
reciprocalspaceship/dataset.py 98.00% <100.00%> (-0.08%) ⬇️
reciprocalspaceship/utils/stats.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7d2a2c...c040f92. Read the comment docs.

Copy link
Member

@kmdalton kmdalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I was not able to find any other places in the code base with offending append statements. To the best of my knowledge, this is complete. The straightforward substitution with rs.concat seems the most natural route too. Sorry for the late reply!

@JBGreisman JBGreisman merged commit 86ea1cb into main May 23, 2022
@JBGreisman JBGreisman deleted the append branch May 23, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Interface Decisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for DataSet.append() due to pandas deprecation
3 participants