Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventSource broken by Node 0.12 #104

Open
rapropos opened this issue Mar 7, 2015 · 2 comments
Open

EventSource broken by Node 0.12 #104

rapropos opened this issue Mar 7, 2015 · 2 comments

Comments

@rapropos
Copy link
Contributor

rapropos commented Mar 7, 2015

Node.js commit nodejs/node-v0.x-archive@f347573 causes eventsource to crash upon subscription because it is attempting to use Infinity as a timeout value:

RangeError: msecs must be a non-negative finite number
  at Object.exports.enroll (timers.js:160:11)
  at Socket.setTimeout (net.js:329:12)
  at pushd/lib/eventsource.coffee:34:20

I don't know what the proper solution is, but I tried changing Infinity to 0x7FFFFFFF and things seem to work.

@rs
Copy link
Owner

rs commented Mar 7, 2015

Could you send a pull request?

@rapropos
Copy link
Contributor Author

rapropos commented Mar 7, 2015

OK, I tried making a pull request. Let me know if I did something wrong, not familiar with the process.

rs pushed a commit that referenced this issue Mar 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants