Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonschema testing: custom validators where never run! #89

Closed
smyrman opened this issue Feb 1, 2017 · 0 comments · Fixed by #90
Closed

jsonschema testing: custom validators where never run! #89

smyrman opened this issue Feb 1, 2017 · 0 comments · Fixed by #90

Comments

@smyrman
Copy link
Collaborator

smyrman commented Feb 1, 2017 •
edited

While working on #88, I discovered that custom validators where never run by the test runner.

UPDATE: unittests for URL and Object have previously silently failed. The failure where due to test issues rather than implementation issues.
smyrman added a commit to smyrman/rest-layer that referenced this issue Feb 1, 2017
@smyrman
jsonschema test bugfix
166a8fa 
Fixes rs#89 where customValidation methods where never run. Also fixes a few broken tests.
@smyrman smyrman mentioned this issue Feb 1, 2017
Merged
@rs rs closed this as completed in #90 Feb 1, 2017
rs pushed a commit that referenced this issue Feb 1, 2017
@smyrman @rs
jsonschema test bugfix (#90)
be9912f 
Fixes #89 where customValidation methods where never run. Also fixes a few broken tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

jsonschema test bugfix smyrman/rest-layer
1 participant
@smyrman