JSON Schema support for schema.Dict #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smyrman
commented
Feb 1, 2017
README.md
Outdated
|
|
||
| ### Custom FieldValidators | ||
|
|
||
| For a custom `FieldValidator` to support encoding to JSON Schema, it must implement the `jsonschema.Builder` interface: | ||
| For a custom `FieldValidator` to support encoding to JSON Schema, it must implement the `jsonschema.Builder` interface: |
There was a problem hiding this comment.
Opps extra space...
smyrman
force-pushed
the
jsonschema-dict
branch
2 times, most recently
from
cf26f74
to
912d4a7
Compare
smyrman
commented
Feb 1, 2017
| }`), | ||
| }, | ||
| { | ||
| name: `KeyValidator=String{Regex:"re"},ValuesValidator=Integer{}"`, |
There was a problem hiding this comment.
should be Regexp in name
smyrman
force-pushed
the
jsonschema-dict
branch
from
912d4a7
to
a289649
Compare
smyrman
commented
Feb 1, 2017
| Validator: &schema.Dict{ | ||
| KeysValidator: &schema.String{ | ||
| Regexp: "tch", | ||
| Allowed: []string{"match1", "match2"}, |
There was a problem hiding this comment.
This test should not have passed...
smyrman
force-pushed
the
jsonschema-dict
branch
from
a289649
to
cfce041
Compare
|
Let's wait for #90 to be merged first and then rebase. |
This commits resolves rs#33 by adding JSON Schema support for schema.Dict. The support limits KeysValidator instances to be a schema.String instance or nil as explained in the README.
smyrman
force-pushed
the
jsonschema-dict
branch
from
cfce041
to
ec5433b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits resolves #33 by adding JSON Schema support for schema.Dict.
The support limits KeysValidator instances to be a schema.String
instance or nil as explained in the README.