Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Predicate operators #188

Merged
merged 3 commits into from
May 25, 2018
Merged

Predicate operators #188

merged 3 commits into from
May 25, 2018

Conversation

torie
Copy link
Contributor

@torie torie commented May 25, 2018 •
edited
Loading

This add support for using the $in and $nin operators in the query package against array fields as described in #187.

It also adds tests for nested fields and the utils.getField function.

@smyrman smyrman requested a review from rs May 25, 2018 08:54
smyrman
smyrman approved these changes May 25, 2018
View reviewed changes
Copy link
Collaborator

@smyrman smyrman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smyrman
Copy link
Collaborator

smyrman commented May 25, 2018

@rs, this allows the mem backend to work more equal to how MongoDB works for $in and $nin queries, making it easier to write unit-tests when using that backend. I don't have any experience with the other rest-layer backends, such as e.g. elastic-search https://github.com/rs/rest-layer-es/blob/c9cca01e407ccc54e6f84f228ac0c45700c5cf96/query.go#L81.

@rs rs merged commit fd06327 into rs:master May 25, 2018
@smyrman smyrman mentioned this pull request Jul 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smyrman smyrman smyrman approved these changes

@rs rs Awaiting requested review from rs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@torie @smyrman @rs