Specifying additional options in --driver-argument results in panic

[feuerrot]

Hi,

I'm trying to run dump1090_rs on a nuc which has multiple rtlsdr connected. AFAICT it should be possible (after using rtl_eeprom to program a different serial number per rtlsdr) to tell SoapySDR which one should be used by appending ,serial=XXXXXXXX to the driver argument.

SoapySDR seems to open the correct device, but dump1090_rs crashes, probably because it tries to lookup some additional options using the full name instead of only rtlsdr?

root@tv ~/src/dump1090_rs (git)-[master] # RUST_BACKTRACE=full cargo run -- --driver 'rtlsdr,serial=00001000'
    Finished dev [unoptimized + debuginfo] target(s) in 0.04s
     Running `target/debug/dump1090_rs --driver rtlsdr,serial=00001000`
[-] using soapysdr driver: driver=rtlsdr,serial=00001000
Found Rafael Micro R820T tuner
Detached kernel driver
Found Rafael Micro R820T tuner
Reattached kernel driver
[INFO] Opening Generic RTL2832U OEM :: 00001000...
Detached kernel driver
Found Rafael Micro R820T tuner
thread 'main' panicked at dump1090_rs/src/main.rs:119:9:
[-] selected --driver gain values not found in custom or default config
[backtrace removed]

I'd guess changing this line to split the options.driver on , before comparing could solve this. I don't know rust but this change seems to work for me:

    let checkdriver = options.driver.split(",").next().unwrap();

    // check if --driver exists in config, with selected driver
    let channel = if let Some(sdr) = config.sdrs.iter().find(|a| a.driver == checkdriver) {

[wcampbell0x2a]

I might rather split that into --driver-extra, as yes, the --driver is used as the key into to default config.toml.

cargo run -- --driver rtlsdr --driver-extra serial=00001000 --driver-extra other=value. Then these would just be used into soapy.

Thanks for finding this!

[wcampbell0x2a]

@feuerrot I pushed #108 which should fix your issue!

[feuerrot]

@wcampbell0x2a thanks! It works for me:

root@tv ~/src/dump1090_rs (git)-[102-add-driver-extra] # target/release/dump1090_rs --host :: --driver-extra 'serial=00001000'
[-] using soapysdr driver_args: driver=rtlsdr,serial=00001000
usb_claim_interface error -6
Found Rafael Micro R820T tuner
[INFO] Opening Generic RTL2832U OEM :: 00001000...
Found Rafael Micro R820T tuner
[-] using config: Sdr {
    channel: 0,
    driver: "rtlsdr",
    setting: None,
    gain: [
        Gain {
            key: "TUNER",
            value: 49.6,
        },
    ],
    antenna: None,
}
[-] Writing gain: TUNER = 49.6
[-] frequency: Ok(1090000000.0)
[-] sample rate: Ok(2400000.0)
[INFO] Using format CS16.
Allocating 15 zero-copy buffers
*8d04008df82100020049b8146635;
*8d04008d5895b55e5d4ddb4577a5;
*8d04008d99098a24f0ac0cc565d2;