Use add/removeFile methods to normalize integration with other component plugins #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschmukler
added a commit
that referenced
this pull request
Sep 3, 2013
Use add/removeFile methods to normalize integration with other component plugins
|
Good call. Thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps things clean for other component plugins. For instance I created a
component-autoprefixerplugin that will autoprefix the css. This needs to happen after stylus transpiling is done.component-autoprefixerwill checkpkg.config.stylesas it should, but it assumes that plugins likecomponent-stylus-pluginare working withaddFileandremoveFiletransparently.Make sense?