Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Makefile target order for parallel build #8

Closed
wants to merge 1 commit into from

Conversation

nfetisov
Copy link

- Replace MY:postamble() with MY::depend()
@rschupp
Copy link
Owner

rschupp commented Jun 20, 2018

I think your analysis in #7 is correct, however I don't like this fix. It relies on a certain order of sections in the Makefile generated by ExtUtils::MakeMaker that could change.
Besides: if you override a method like depend() you should respect its interface - e.g. what would happen if someone added a "depend" argument to the call of WriteMakeFile().
Fixed in 04a133b by using adding a .NOTPARALLEL target.

@rschupp rschupp closed this Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel build rules dependancy problem
2 participants