Fixes #48, convert method to TryGet. #49
Conversation
| protected internal virtual LambdaExpression TryGetConvertExpression(Type from, Type to) | ||
| /// <param name="expr">Expression that converts a value of type <i>TFrom</i> to <i>TTo</i> or null.</param> | ||
| /// <returns><see langword="true" /> for successful expression, <see langword="false" /> if failed..</returns> | ||
| protected internal bool TryGetConvertExpression(Type from, Type to, out LambdaExpression expr) |
There was a problem hiding this comment.
CJ uses return null-as-none pattern in multiple places, not only in ConvertBuilder.
As for me there's no profit with converting these into Try(… out var).
Vote to decline.
There was a problem hiding this comment.
Returning null is not good idea and not suggested in most coding conventions.
Modern C# has out var which makes usage of TryGet functions very easy and safe.
There was a problem hiding this comment.
I suggest to call these methods with OrDefault suffix at least.
There was a problem hiding this comment.
Let's continue here (rus).
There was a problem hiding this comment.
What is our conclusion ?
https://rsdn.org/forum/prj.codejam/7300161.1
|
According to poll https://rsdn.org/poll/6564 |
No description provided.