Add quit::main macro
#29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
=======================================
Coverage 80.58% 80.58%
=======================================
Files 15 15
Lines 4482 4482
=======================================
Hits 3612 3612
Misses 870 870
Continue to review full report at Codecov.
|
|
Thank you so much, this is really helpful! I must've misread the documentation 😅 |
|
Thank you too! This lets me know I should add a note about this in the documentation for |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I was searching to see how my crates are being used and noticed that the
quit::mainmacro is missing here, which Quit uses to set the exit code. Without it, the exit code will end up being 101, but relying on this is not ideal. This PR fixes that.